-
Notifications
You must be signed in to change notification settings - Fork 17
docs: Add runnable code blocks #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08de799 to
ed95675
Compare
| @@ -0,0 +1,95 @@ | |||
| const { createHash } = require('node:crypto'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any plan to import this code? Apart from one env var name, it is a copy from the crawlee repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The roa-loader is just copied from crawlee repo, no changes from my side.
(The duplication of website-related logic is a separate issue.)
- Set headless mode to True by default to improve performance when running via "Run on Apify", preventing slow execution and potential timeout errors. - Align the Python example more closely with its JavaScript counterpart to keep the documentation consistent across languages. - Add `asyncio.run(main())` so the snippet is fully copy-and-play ready. - Also, a minor update regarding the docs code examples (same as in apify/apify-sdk-python#673).
example-code-runner-pyare done (https://github.com/apify/example-code-runner-py/pull/11).Actor_is_any_instance_initializedis not reset correctly after exiting Actor context #674TODO